News homepage

Community feedback

• 

  Arshad Ali Kaldane•650

  @IamArshadAliPosted 12 months ago

  Hello there! 👋

  Congratulations on completing this challenge. 🎉

  I do have some suggestions that might interest you. 💡

  • Starting with structuring your project, I recommend this article which teaches you how to create an organized folder structure that will make your project flexible.

  project
  -src
  --assets
  ----images
  ------img.png
  --components
  ----Header.jsx
  --App.js
  --README.md
  

  • Use Barrel Exports to organise your React Components. You can do the same with importing images and svg's .

  --assets
  ----images
  ------index.js
  
  // assets/images/index.js
  import gamingGrowth from "./image-gaming-growth.png";
  import retroPCs from "./image-retro-pcs.png";
  import topLaptops from "./image-top-laptops.png";
  
  export { gamingGrowth, retroPCs, topLaptops }
  
  // components/Extras.jsx
  import { gamingGrowth, retroPCs, topLaptops } from "../assets/images"
  

  • Instead of using <h1> for the logo, use logo.svg that was provided with the starter files.

  • @media (min-width: 768px) {...} is usually used to style your elements for medium size devices like tablets, use @media (min-width: 640px) {...} to style for mobile

  Above all your solution is great and I'm inspired by how well you've utilized semantics HTML to structure your code. ✌️

  Good luck with the upcoming challenges. 👍

  Hope you found this feedback useful. 🚀

  Happy Coding. 🤓

  0

  ---

  

  JAYSONRK•500

  @JAYSONRKPosted 12 months ago

  @IamArshadAli thank you very much for your valuable feedback. I will work on these.

  1