News Homepage

Community feedback

• 

  Alexandra•580

  @Alexandra2888Posted about 1 year ago

  Hi! Congrats on finishing challenge! Your solution is very close to the design! Here are some things I think you can improve:

  • use more semantic HTML instead of divs,
  • use figure to wrap img tag for screen readers,
  • don't leave alt tag empty,
  • you can implement BEM naming convention, it will help you in larger projects and when you will use SCSS also.

  Tip in larger projects: when you have multiple html, css files use folders: index.html (main file, stays in root of the project) css/common.css (if you have common styles from all html, to avoid code repetition) /styles.css (styles from index.html) /news.css(styles from news page) news/news.html(page for news) js/main.js(js for index.html) /news.js(js for news.html) Happy coding!

  Marked as helpful

  0

  ---

  

  Nature Son•1,100

  @NatureSon22Posted about 1 year ago

  @Alexandra2888, I'll make sure to remember those points. Thank you ;3. About your third recommendation, I came across information indicating that if an image serves only a decorative purpose, it's okay to leave the alt attribute empty.

  0