News Homepage

Community feedback

• 

  Ali AbuEl3iz•220

  @ali007-depugPosted 11 months ago

  well done, it's include semantics HTML like main and section, also you can use "header" for logo and desktop navBar, for accessible,test it on browser dev tool on my phone the layout is very good your code is readable but try to write some comments on css and i noticed that you are using only id , why no " class " instead .. read some article about using class and id and what is best practice

  1

  ---

  

  Damian Kurkowicz•460

  @Kurkov11Posted 11 months ago

  @ali007-depug Yeah I should've used the header tag. Commenting in CSS could be a good idea to explain some decisions. I was using classes only for elements that were reused throughout the project and id's for elements that weren't.

  0

  

  Ali AbuEl3iz•220

  @ali007-depugPosted 11 months ago

  @Kurkov11 with all luck

  0