Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters
Not Found

Submitted

News Homepage

@Kurkov11

Desktop design screenshot for the News homepage coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback is welcome

Community feedback

@ali007-depug

Posted

well done, it's include semantics HTML like main and section, also you can use "header" for logo and desktop navBar, for accessible,test it on browser dev tool on my phone the layout is very good your code is readable but try to write some comments on css and i noticed that you are using only id , why no " class " instead .. read some article about using class and id and what is best practice

1

@Kurkov11

Posted

@ali007-depug Yeah I should've used the header tag. Commenting in CSS could be a good idea to explain some decisions. I was using classes only for elements that were reused throughout the project and id's for elements that weren't.

0

@ali007-depug

Posted

@Kurkov11 with all luck

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord