Design comparison
Solution retrospective
My first project when I created the mobile view first and after that made rest of the views.
I'll be grateful for every feedback. :)
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Remove ❌
<div class="wrapper">
as it is unnecessary.
- The "navigation toggle" should be inside the
nav
element and be created with thebutton
element.
- ⚠️ The "The Bright Future of Web 3.0?" should be an
h2
heading, not anh1
.
- Check the "active-states" design file (provided on the FEM files) to which text elements need created with the
anchor
element.
- Numbers are not headings ❌.
- Your
CSS Reset
is being underutilized. 😢 To fully maximize 💯 it, you will want to add more to it. Here are some examples that you can freely use 😁: Josh Comeau Reset Eric Meyer Reset
- For improved accessibility 📈 for your content, it is best practice ✅ to use
em
formedia-queries
. Using this unit gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful0@sztosiurPosted almost 2 years ago@vcarames Again thanks for your help and feedback.
About
<div class= "wrapper">
: I made it to keep the site content not too wide on a big screens. It sets themax-width: 1250px;
and it centers the content horizontally. Do you want me to make content spread all over the viewport width?1@VCaramesPosted almost 2 years ago@sztosiur
Glad I could help! 😁
That is the incorrect way of accomplishing that.
That’s what the
header
,main
and<section class="section-3">
are for. You apply the CSS to them so the content is centered to the page.Marked as helpful0 - Remove ❌
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord