News homepage with GRID / FlexBox / JS

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Remove ❌ <div class="wrapper"> as it is unnecessary.

  • The "navigation toggle" should be inside the nav element and be created with the button element.

  • ⚠️ The "The Bright Future of Web 3.0?" should be an h2 heading, not an h1.

  • Check the "active-states" design file (provided on the FEM files) to which text elements need created with the anchor element.

  • Numbers are not headings ❌.

  • Your CSS Reset is being underutilized. 😢 To fully maximize 💯 it, you will want to add more to it. Here are some examples that you can freely use 😁: Josh Comeau Reset Eric Meyer Reset

  • For improved accessibility 📈 for your content, it is best practice ✅ to use em for media-queries. Using this unit gives users the ability to scale elements up and down, relative to a set value.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  0

  ---

  

  sztosiur•110

  @sztosiurPosted almost 2 years ago

  @vcarames Again thanks for your help and feedback.

  About <div class= "wrapper">: I made it to keep the site content not too wide on a big screens. It sets the max-width: 1250px; and it centers the content horizontally. Do you want me to make content spread all over the viewport width?

  1

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @sztosiur

  Glad I could help! 😁

  That is the incorrect way of accomplishing that.

  That’s what the header, main and <section class="section-3"> are for. You apply the CSS to them so the content is centered to the page.

  Marked as helpful

  0

  

  sztosiur•110

  @sztosiurPosted almost 2 years ago

  @vcarames ok, I'll fix that. Thanks again. :)

  0