Responsive News homepage using CSS Grid and Flexbox

Community feedback

• Account deleted

  1. You should give alt text to every image. It helps those know what it is about incase the image doesn't load on their device. The alt text for image one and three are is decent. For the third image use a shorter alt. Try to be descriptive in as few words as possible. For e.g. you could call it "a modern-day keyboard".
  2. It's more appropriate to have the headings inside the <a></a> tags. The way you did it makes only the text clickable, if you did the other way around the complete line would be clickable which is more common. Like most other choices in web development it is not a choice of how valid it would be, if you prefer it that way, that's fine as well. But I'd recommend putting the h2 in the <a></a>
  3. Try not to use so many divs. Tags like aside section footer provide more semantic meaning.

  Marked as helpful

  1
• 

  Nelson•2,390

  @nelsonleonePosted almost 2 years ago

  Hello , congrats on completing this challenge 🎉 🎉 🎉 Nice solution Hope this comment was helpful

  Yes, only add alt= if the image sends a message, if they are just for decoration, use an empty alt="" and set aria-hidden="true"

  And the headers, if they don't lead anywhere(link) there's no use adding a <a> to them

  Happy coding 🎉 🎉

  Marked as helpful

  1