SCSS, CSS Grid, Mobile-first workflow, Vanilla JS

Community feedback

• 

  madhaus•1,040

  @festsnusaPosted almost 2 years ago

  Hi there! Congratulations for completing this challenge.

  I'm quite impressed by your page's design with transitions and animations. So, I'm gonna skip to advices to how to make your code look more concise:

  • importing fonts from Google Fonts are not recommended, because link may change or may become unavailable. So, instead of importing, I recommend you to download it. you can use "google-webfonts-helper";
  • instead of px, you should use rem;
  • in your scss code, i've noticed that you constantly put the whole selectors inside selector. perhaps, you should use BEM;
  • you can switch to Pug, include mixins and separate your page into components.

  P.S.: I've noticed a bug:

  • when u open nav menu and switch to desktop resolution, your ul will look kinda messy.

  Hope you find my feedback useful. Happy coding!

  Marked as helpful

  0

  ---

  

  coderwww•220

  @coderwwwPosted almost 2 years ago

  @festsnusa Thanks a lot! I have fixed the bug with the menu I'm also going to look into the other stuff you wrote about )

  0