Design comparison
Solution retrospective
Built this Responsive News Homepage using CSS Flexbox
Community feedback
- @eewa-SANJPosted almost 2 years ago
Hello!. Your solution looks good but I have gone through your code. There are a few issues found in your codes. Here are my findings.
-
Your site is not responsive, so it crashes and overlap here and there. You can fix those issues using media queries. If you want to help me more, contact me and I will help you
-
Your favicon is not rendered due to the wrong path. Could you fix it?
-
Your main image(image web 3 desktop) only rendered in small screens. But on small screens, your mobile version of that image should be rendered.
<img srcset="assets/images/image-web-3-mobile.jpg 686w, assets/images/image-web-3-desktop.jpg 1460w" sizes="(max-width: 375px) 686px 1460px" src="assets/images/image-web-3-desktop.jpg" alt="Web 3.0" >
. If you want how to implement this Read this -
There is an alignment issue in your sidebar and below three column divs. You can adjust it by resizing the sidebar according to the three-column width.
-
You have missed the mobile hamburger menu in the tab and mobile screen sizes
I think, my findings will help you to improve your coding.
Happy coding😊
Marked as helpful1@okraksPosted almost 2 years ago@eewa-SANJ thanks for pointing these out! I'll be fixing these issues
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord