News Homepage w/SCSS

Community feedback

• 

  S MD suleman•3,530

  @sulemaan7070Posted almost 2 years ago

  hey 😄Mustafa DEDE, congratulations on completing the challenge... here are a few tips to make your site better.

  1.I see that you have applied only the desktop-image on both the desktop and the mobile versions.. you will find the image-web3-mobile in the images folder.. you can responsively change the image based on the media-query..

  2.Using the picture element for responsively switching between Images is considered as best practice

  <picture>
    <source media="(min-width: 650px)" srcset="img_food.jpg">
    <source media="(min-width: 465px)" srcset="img_car.jpg">
    <img src="img_girl.jpg">
  </picture>
  

  more about picture element here📚

  3.The images in the .wrapper divs are squeezed...using the property object-fit :contain will prevent the images from being squeezed or stretched..

  hope that helps, happy coding💯🔥👍🏻

  Marked as helpful

  1

  ---

  

  Mustafa DEDE•130

  @mustafadedePosted almost 2 years ago

  @sulemaan7070 Thanks for the feedback! I changed it. Btw I didn't know <picture> <source> thing. Thanks.

  1