Design comparison
Solution retrospective
I would be very happy if you could help me with the parts I need to improve. Thank you for your feedback.
Community feedback
- @AdonaikjrPosted almost 2 years ago
Hello friend, your project is perfect the only thing I have to say but not very relevant would be the css classes do not use main, section, article as class name use ContainerSection, ContainerArticle, ContainerMain so stop giving these errors, congratulations project was perfect
0 - @AdrianoEscarabotePosted almost 2 years ago
Hi Taha, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
You have used <br> , using <br> is not only bad practice, it is problematic for people who navigate with the aid of screen reading technology. Screen readers may announce the presence of the element. This can be a confusing and frustrating experience for the person using the screen reader. You can read more in MDN.
Every html document must contain a main tag, to inform what is the main content of the page, as this page is a complete page, that is, it has a header a main and the footer, wrap the main content with the main tag , for users who use screen readers, to be able to understand what the main content of the screen is!
The rest is great!
I hope it helps... 👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord