Submitted almost 2 years ago
Responsive News Home Page using CSS Flexbox and Grid
@BishwashKumarSah
Design comparison
SolutionDesign
Solution retrospective
Hello Everyone. This is my second project on this site. Any Suggestions would really be appreciated. Happy Coding.
Community feedback
- @catherineisonlinePosted almost 2 years ago
Looks awesome. Might need to change the menu blue color from blue to grey, wrap everything in the main tag instead of div (with the class container) and add alt="" to the images.
Marked as helpful1 - @amalkarimPosted almost 2 years ago
Hi Bishwash, congratulations for completing the challenge!
Please allow me to give some suggestions to make your great solution even better.
- Try to visit the preview site using smartphone. There, we can scroll to the right and can see the sidebar menu even though it's not opened yet. To fix this, we could add this style to prevent that from happening:
html, body { overflow-x: hidden; }
- Also, when using smartphone, the hero image looks squeezed because its width and height are not proportional. To fix this, let's add
object-fit: cover;
to<img src="images/image-web-3-desktop.jpg">
.
Hope this helps. Happy coding!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord