Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

News Home Page with Grid and Flex(Fake menu icon)

@MichaelKanios

Desktop design screenshot for the News homepage coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi all , I used Grid and Flex. I made a fake hamburger menu because i dont want just copy paste code from another sorce . I prefer to learn first .Thanks for your time

Community feedback

Adriano 34,090

@AdrianoEscarabote

Posted

Hi Michael Kanios, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

I noticed that the content is going to the side after activating the max-width, to solve this we can add a margin in the body:

body {
    margin: 0 auto;
}

every html document must contain a main tag, to inform what is the main content of the page, as this page is a complete page, that is, it has a header a main and the footer, wrap the main content with the main tag , for users who use screen readers, to be able to understand what the main content of the screen is!

The rest is great!

I hope it helps... 👍

Marked as helpful

0

@MichaelKanios

Posted

@AdrianoEscarabote Thank you very much for your great response. I made the changes that you suggest me.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord