News Home Page By Micah.

Community feedback

• 

  Chukwudobe Micah Chinedu•700

  @chukwudobe-MicahPosted about 2 years ago

  Hey, thank you for taking time to check and review my code. I just learnt this picture tag, I'll start using it instead of display: none; and display: block; since it's more semantic! Also, after finishing my code, I noticed that the "new" was an aside, I'll also change that too. I don't know JavaScript yet, so that's why I didn't add a navigation, I'm learning Js now so I'll probably add one in the future. Thanks again for the reviews, I learnt some things here and I'll try them.

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • You challenge is not complete*. It needs to have a mobile navigation to be considered complete.

  • The Alt Tag description in the logo needs to be improved upon. So the description should state the company name.

  • Your navigation links in the header need to be wrapped inside a nav element and each individual link needs to wrapped inside a anchor tag.

  • The "nav button" needs to be inside the nav element before the nav menu.

  -The "hero image" uses two images 🎑 at different breakpoints. The picture element will facilitate this.

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  https://web.dev/learn/design/picture-element/

  • The "New" component should be an aside element.

  • Everything that has a :hover effect should be created using a anchor tag.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  0