Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

newbiew QR code challenge with basic HTML and CSS.

@timbosTours

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


As this is my first challenge I am looking for some general feedback. I had some trouble with positioning on both the card itself and the image on the card. I want to know how I get from this, too industry best practices. Thank you for taking the time to revue my code.

Community feedback

Adarsh Rai 560

@AdarshRai0

Posted

Hello Timothy Fawcett, congratulations for your solution!

If you want to improve your solution a bit I've two advice for your: Semantic tags

The direct children of the body must be wrapped in semantic tags to indicate users about the various purposes of different parts of a webpage.

For example,

  <header>
    ...header of the webpage...
  </header>
  
  <main>
    ...main content of the webpage...
  </main>
  
  <footer>
    ...footer of the webpage...
  </footer>
</body>```

Marked as helpful

0

@timbosTours

Posted

@AdarshRai0 Thank you very much for taking the time to review my code. Getting better at accessibility is one of the main reasons I joined front end mentor. I will do some more reading on semantic HTML and update my code. Cheers :)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord