Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi HteinLinn, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add
main
tag and wrap the card for Accessibility - add descriptive text in the
alt
attribute of the image - remove all
margin
fromcontainer
class - try to use flexbox to the body for center the card. Read here -> best flex guide
- after, add
min-heigth: 100vh
to body because Flexbox aligns child items to the size of the parent container - try to add a little
transition
on the element with hover effect - for fix the opacity of eye in hover effect of image not use
opacity
to.equilibrium-hover
but use thergba()
in the background color of.equilibrium-hover:hover
state
Overall you did well :)
Hope this help and happy coding!
Marked as helpful0 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord