Design comparison
SolutionDesign
Solution retrospective
Any pro tips or advice welcome. Criticism is welcome too. Have at thee!
Community feedback
- @MelvinAguilarPosted 11 months ago
Hello there ๐. Good job on completing the challenge !
I have other small suggestion about your code that might interest you.
- You can wrap the text and the icon in a single button. This is because when you click the text, the element should open/close, not just the icon.
- If the image is purely decorative, meaning it's an icon that doesn't add any essential information to the page, you can leave its alt attribute empty so that screen readers can ignore the image.
<span>
is an inline element used for styling but is not a semantic tag. You should use paragraphs or headings to better describe your page's content.
I hope you find it useful! ๐
Happy coding!
0 - @danielmrz-devPosted 11 months ago
Hello Gareth!
You did a very good job there!
I have just a couple of very simple suggestions for improvement:
- Since the plus/minus icon and the question are clickable elements, it's nice to add
cursor: pointer
to them.
๐ This gives the user a visual indication that the element is clickable, as obvious as it may look.
Other than those details, you did a great job!
0 - Since the plus/minus icon and the question are clickable elements, it's nice to add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord