Design comparison
Community feedback
- @mattstuddertPosted over 5 years ago
As far as
px
vsem
I'd actually recommend looking into usingrem
units. They look directly at thehtml
font-size
and so are much easier to use thanem
units, but much more flexible/maintainable than pixels.1@DanielGibsonOrchidPosted over 5 years agoThanks Matt. This website is very helpful. Thanks for the advice on using rem.
What do you think about padding/margins, best to use percentage?
What about declaring the size of a section, best to use width/height on the <section> tag or let the content fill the section and adjust the size with padding/margins?
0@mattstuddertPosted over 5 years agoI would also recommend
rem
for padding/margins, as then spacings scale down with the text size as it changes for different screen sizes.I very rarely set
height
on an element. It's usually much better to just addpadding-top
andpadding-bottom
and then let its height be dictated by the content inside.1 - @SimpleMBPosted over 5 years ago
Looks awesome! Try to use <section> not <div>. Why Us is better with item list <ul> and <li>.
1@DanielGibsonOrchidPosted over 5 years agoThanks for the feedback. Will use it for next time
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord