New solution with Bootstrap

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,060

  @MelvinAguilarPosted about 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  • You can use relative file paths in your images, this can save future errors in your images:

    <img src="./qr-code-component-main/images/image-qr-code.png" alt="QR code to frontendmentor.io">
    

    More information.

  • tip: For the image folders, you can name the folder "assets" instead of "qr-code-component-main".

  CSS 🎨:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. You can read more about this here 📘.

  • Use min-height: 100vh instead of height: 100vh. The height property will not work if the content of the page grows beyond the height of the viewport.

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  2

  ---

  

  Glozsa•180

  @GlozsaPosted about 2 years ago

  @MelvinAguilar You are a lifesaver!

  1