Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

New page challenge

Grace 140

@gws-jenny-andrews

Desktop design screenshot for the News homepage coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Struggled a bit with the slide in/out of the mobile menu. It slides out fine, but not back in again. Any suggestions greatly received

Community feedback

Adriano 34,090

@AdrianoEscarabote

Posted

Hi Grace, how are you? Welcome to the front-end mentor community! I really liked the result of your project, but I have some tips that I think you will enjoy:

I noticed that you used a button in which case the best option would be an a, because in my head when a person clicks on a button written Read more, he is not confirming a form, or something like, it will be redirected to another page, to read more about!

to solve this problem do this:

<a href="/">Read more</a>

Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem

The rest is great!

I hope it helps... 👍

Marked as helpful

0

@amalkarim

Posted

Hi Grace 👋

Congratulations for completing your first challenge!

I don't know but I think there are quite complex styling regarding your menu navigation. Looking at my own solution, here is the similar approach to make the mobile menu slide in/out smoothly.

nav {
    width: 330px;
    position: fixed;
    transition-delay: 0ms;
    transition-duration: 500ms;
    height: 100vh;
    right: -330px;
    top: 0;
    display: flex;
    flex-direction: column;
    background: white;
}
.nav-open nav {
    right: 0;
    transition-duration: 500ms;
}

@media (min-width: 1025px) {
    ....
    ....
    nav {
        width: auto;
        height: auto;
        position: static;
    }
    ....
    ....
}

Feel free to check out my solution here

Let me know if you still have any question. Happy coding

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord