New Homepage Main Responsive

Community feedback

• 

  salma fadl azzam•330

  @salmafadlabdulrahmanPosted almost 2 years ago

  Hello there, You did a great a job on this project👏, I have a few tips for you that might help. I hope it's alright.

  you have put the 3 cards/articles in a footer tag. it would be better if you put in a section tag, or a div tag. the footer tag actually contains information about the author of the section, copyright data or links to related documents.

  also make sure to add a margin top to the cards/articles section so it doesn't overlap, and add max width to the the main section so the contents won't clash and overlap.

  use max width on the images, so when the page size gets smaller the image would shrink but what's inside of the image should be the same.

  There's a course named Responsive web design on Scrimba.com, there's multiple units about grid, and flexbox, I took the course and I found it very helpful and learned new stuff.

  Great job working on this project!!👏👏

  Marked as helpful

  0

  ---

  

  rayzii-gh•160

  @rayzii-ghPosted almost 2 years ago

  Thanks, in paragraph 4 you mean the default of the image size?

  1

  

  salma fadl azzam•330

  @salmafadlabdulrahmanPosted almost 2 years ago

  @rayzii-gh yes, say you have a container and there's an image in it, you need to determine the width / the max width that the image should consume in that container, this is a part of making your website responsible. 👏

  Marked as helpful

  0