Skip to content
Submitted almost 2 years ago

Need a lot feedback

Nohelynaid•180
@Nohelynaid
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Need a lot of feedback. I'm still struggling with mobile layout. I'm trying to learn by my own without using tools. I know that might be weird, I guess but I want to get hands on this before trying tools to do it.

Community feedback

  • Hassia Issah•50,650
    @HassiaiPosted almost 2 years ago

    Replace <div class="main"> with the main tag and <h4> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

    Add the language attribute to the html tag <html lang="en"> and add the alt attribute alt=" " to the img tag containing the avatar.

    For a responsive content which wont require a media query for this challenge. replace the width in .main with max-width and increase it value. max-width:400px.

    Replace the height in .card with a padding value fo r all the sides, this will prevent the content from overflowing on smaller screens and its a responsive replacement. padding: 20px. There is no need to give .main position: absolute and its properties.

    Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

    Hope am helpful.

    Well done for completing this challenge. HAPPY CODING

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord