myteam multipage SCSS / Vanilla JavaScript

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hello, ElieB77! 👋

  Wonderful job on this challenge! 👍 Everything looks pretty good and responds quite nicely! 👏 As emestabillo mentioned, your attention detail is great! 🙌

  I just suggest adding some alt text to the logos on the page to clear up your solution report a bit. 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Elie Bissor•265

  @ElieB77Posted almost 4 years ago

  Hello @ApplePieGiraffe,

  Thanks for the compliments,😉 I'm a little disappointed regarding the margins and padding though, I need to find a tool that give me the exact pixels of white space between elements on the figma design file..

  I know, I always neglect the alt, 😂 I've tried to edit the sass files directly on github but changes doesn't apply.. Do you know if I can do that or do I have to go back to vs code to edit the files and reupload everything on github ??

  Thanks for the feedback ! 😉

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  @ElieB77

  If you use Figma to access and use the design files, you can select an element and then press the alt key and hover over other items with your cursor to see the exact distance between those elements in pixels. Also, check out this Chrome extension called PerfectPixel—it allows you to overlay images over your website to see exactly how your website matches up with the design. 😀

  As for the alt text, all you need to do is edit the HTML file in VS Code and then stage, commit, and push your changes to GitHub. If you linked your project in Vercel to a GitHub repository and you pushed the new changes to the master branch of your project (and it looks like it's set up that way by default), your website should automatically update to reflect those changes in a few minutes.

  Let me know if that helps! 😉

  1
• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted almost 4 years ago

  Hey Ellie, awesome work! Love the attention to detail. The only thing I saw was that when I check it on mobile ios, I get a horizontal scroll on the homepage. Would've also been great to see some transitions on the flip cards, but that's a minor thing :-)

  1

  ---

  

  Elie Bissor•265

  @ElieB77Posted almost 4 years ago

  Hey @emestabillo,

  I thought I fixed the horizontal scroll by adding <meta name="viewport" content="width=device-width, initial-scale = 1.0, maximum-scale=1.0, user-scalable=no" /> (even though it's not recommended)

  I guess the chrome responsive tool is not that accurate, If you know of a better and more accurate tool for responsiveness, feel free to share ! 😜

  As for the flip cards, I got lazy ..

  Thanks for your feedback ! 🙌

  1
• 

  Jesutofunmi•80

  @tofydeboPosted almost 4 years ago

  You did a good job there

  1

  ---

  

  Elie Bissor•265

  @ElieB77Posted almost 4 years ago

  Thanks @tofydebo ! 👍

  0
• 

  Elie Bissor•265

  @ElieB77Posted almost 4 years ago

  Yes it does ! Thank you !🙌

  0