Skip to content
Submitted over 1 year ago

my-soltion-social-proof-section-master

Alan•350
@alanrsouza04
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social proof section
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I had a problem with extra spaces on the sides and I couldn't find the error so I would like some help

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    DECORATIVE SVG'S ♨️:

    • The alt attribute is used to provide alternative text for images in HTML documents. The alt attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.
    • Now, when it comes to decorative SVGs, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.
    • Since these images do not convey any important information or functionality, there is no need for an alt attribute.
    • So feel free to set the alt attribute as "" for decorative svg's, because alt="" will be skipped by screen readers they will consider the image as decoration

    Example:

    <img src="images/decorative.svg" alt="">


    <img src="./images/icon-star.svg" alt="icon-star">
  👇
<img src="./images/icon-star.svg" alt="">

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    0
  • Saad Hisham•1,750
    @Saad-HishamPosted over 1 year ago

    Great work! 👏 I couldn't find any issues with your website, but I do have a couple of suggestions that might help improve it.

    Firstly, it would be good to adjust the margins and padding for a more polished look. You can experiment with different values until you find the right balance

    Secondly, don't forget to add a favicon! It's a small detail, but it can make a big difference in how your website looks and feels. Here's an example of the code you can use:

    <head>
  <link rel="icon" type="image/png" href="favicon.png">
</head>

    Just make sure to replace favicon.png with the actual filename and extension of your favicon file.

    That's all! Keep up the great work and happy coding! 💖"

    Marked as helpful
    0
  • Edgar•220
    @edgarbp95Posted over 1 year ago

    The problem is in the padding 10% that you are giving to the main. Remove it and you won't have the scroll problem.

    Look for another way to center it, like enclose it in div, give the body 100vh, and center it with flex, justify-content:center, aling-items:center (could be an option).

    Good luck!

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord