Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

My version of the QR card

Gian Ramelbβ€’ 160

@rame0033

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I recently finished my web development I course from my college so I tried the first time to use frontend mentor to keep me on track and practice what I've learned. I learned to use comment everytime on my code so that I keep track on which parts I've made and the use of modular scaling for texts instead of pixels.

I used also a CSS reset for this one since it made me comfortable to style freely and being more precise somehow with my spacing.

Community feedback

@MelvinAguilar

Posted

Hello there πŸ‘‹. Good job on completing the challenge !

I have only one suggestion about your code that might interest you.

  • You can use the following styles to center the element effectively using either of these two methods: For Grid:

    body {
      min-height: 100vh;
      display: grid;
      place-items: center;
      /* Additional styles if needed */
    }
    

    For Flexbox:

    body {
      min-height: 100vh;
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
      /* Additional styles if needed */
    }
    

    Later, you can remove this margin:

    main, footer {
      /* margin: 6vh auto; */
    }
    

I hope you find it useful! πŸ˜„

Happy coding

Marked as helpful

2

Gian Ramelbβ€’ 160

@rame0033

Posted

@MelvinAguilar thank you for this tip. Honestly, didn't know this since we're using margin all the time during our class.

Really appreciate this wonderful tip πŸ˜„

0
Daniel πŸ›Έβ€’ 44,230

@danielmrz-dev

Posted

Hello @rame0033!

Your project looks great!

I noticed that you used margin to place the card in the middle of the page. Here's a very efficient way to center the card:

  • You can apply this to the body (in order to work properly, you can't use position or margins):
body {
    min-height: 100vh;
    display: flex;
    justify-content: center;
    align-items: center;
}

I hope it helps!

Other than that, you did a great job!

Marked as helpful

0
Gian Ramelbβ€’ 160

@rame0033

Posted

Any feedback and suggestions will be highly appreciated. Thank you! :)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord