my take on qr code website

Community feedback

• 

  backyardcaveman•40

  @backyardcavemanPosted over 1 year ago

  Good work on your first challenge! Here are a couple thoughts that could help in the future:

  First is the use of semantic HTML, which would be the difference of using the <main> tag as opposed to where you used the <section> tag. This helps with user accessibility as well as search engine optimization. https://www.youtube.com/watch?v=kX3TfdUqpuU

  Second of all is the use of units in css files. Pixels were used for font size, padding and margin when preferably you would use different units for different tasks; like em's or rem's for font size for example. Some units of measurement are absolute and some scale to the size of the application, so its good to know what works best and when. https://www.youtube.com/watch?v=N5wpD9Ov_To&t=294s

  All the best, and happy coding!

  Marked as helpful

  1
• 

  Md Abid Hussain•400

  @md-abid-hussainPosted over 1 year ago

  Great job on completing this challenge

  However you need to make it responsive and you have to look for padding as well. Following are the resources that might help you :

  1. Responsive design tips
  2. Responsive design made easy
  3. Margin and Padding deep dive

  Marked as helpful

  0
• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  To center a content on a page using flexbox or grid USING FLEXBOX: body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; } USING GRID: body{ min-height: 100vh; display: grid; place-items: center; } Hope am helpful.

  1