Design comparison
Solution retrospective
Wanted to build with grid layout and struggled a bit. Let me know if there are better solutions. Feel free to leave any others comments as well.
Community feedback
- @KrishnaVishwakarma1595Posted about 1 year ago
Hi, @Ulrich1979
-
Instead of using
width: 100vw
for yourid="main"
, you can usewidth:100%
. Thiswidth:100vw
creates an unnecessary horizontal scroll on your design. -
For
id="container"
, there is no need forheight: 446px;margin: auto;
-
As you are using grid column
1fr fr
, there is no need to provide the width & height for theid="image-part"
, you can give thiswidth: 100%;height:100%
Hope these points will help you. Although, great solution. Congrats on completing the challenge.
Happy Coding
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord