Submitted about 1 year ago
My solution to the Social proof section challenge
@NathanRayM
Design comparison
SolutionDesign
Solution retrospective
Hello Everyone.
Here is my solution for the Social Proof section challenge. I did find positioning the elements challenging but am excited that I am learning more and more CSS and HTML. As always.....any feedback that can help me improve is welcome.
Community feedback
- @vickievienPosted about 1 year ago
Awesome job! It looks really good and super comparable to the solution! A few points to consider:
- Alt text: include text instead of leaving it blank for accessibility purposes. It allows screen readers to read what this image is, if not, they'll have no idea it's a star. -- e.g. the stars could be something like alt="yellow star" or "yellow star rating".
- Semantic HTML tags: I would try to swap out some of the
div
s and usesection
andarticle
for accessibility purposes also! It also helps with SEO down the line! -- e.g. updating the top container and bottom containers to besection
and each review box to bearticle
Hope this helps. Happy coding!!
Marked as helpful0@NathanRayMPosted about 1 year ago@vickievien Awesome! Thank you. I will go back and make some changes.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord