@Islandstone89
Posted
Some additional tips:
HTML:
-
"Learning" is a paragraph, not a heading. Headings are meant to represent other content that follows.
-
I would wrap the date in a
<time>
tag. -
The profile image should be placed in the HTML as an
<img>
, and it must have a short and descriptive alt text. -
It is generally not recommended to set fixed widths and heights in
px
. The only width the card needs is amax-width
of around20rem
, so it doesn't get too wide on larger screens. -
Headings must always be in order, so change
<h3>
to a<h2>
.
CSS:
-
height
onbody
should bemin-height
- this way, the content will not get cut off if it grows beneath the viewport. -
I'm not sure you need a media query, when they are needed they must be in rem instead of
px
. It is also best practice to do the mobile styling as the default.