My solution of the card component challenge

Community feedback

• 

  Bryan Li•3,530

  @Zy8712Posted 10 months ago

  Hi there! Your site looks pretty good. The only thing I'd really change is how you implemented the circles as the background for your website. When you are placing decorative background images it is probably best for you to use the background-image css property.

  An example of one way you could place the two circles is:

    background-color: var(--theme-dark-cyan);
    background-image: url("./images/bg-pattern-top.svg"), url("./images/bg-pattern-bottom.svg");
    background-repeat: no-repeat, no-repeat;
  
    /* top img is offset 52 percent of the vw from the right and offset 35 of the vh from the bottom*/
    /* bottom img is offset 48 percent of the vw from the left and offset 52 of the vh from the top*/
    background-position: right 52vw bottom 35vh, left 48vw top 52vh;
  

  Hope this helps 👍

  Marked as helpful

  0