My solution for this challenge

Community feedback

• 

  Bernardo Poggioni•5,280

  @R3ygoskiPosted 6 months ago

  Hello @Arirockdev, congrats your solution is really good and close to the proposed design.

  A tip about you HTML, your HTML structure is right, but I noticed that it's not semantic, and it's very importante to focus on semantic HTML, because it's increase your page Accessibility and SEO, so here some examples where you could use semantic HTML:

  • <div class="header"> you could use a <header> tag instead of <div>.
  • <div class="main"> you could use a <main> tag because it's the main content of the page.
  • <div class="hero"> you culd use a <figure> tag because it's the main image of your project, or because it's related to the main content.

  And so on.

  And this animation in your Navbar, when you open the hamburguer menu, it's very awesome, I really liked it.

  Again, congrats, keep the good job, and if something I said was unclear, please, comment below and I will try to help in the best possible way.

  Marked as helpful

  0

  ---

  

  Arirockdev•450

  @ArirockdevPosted 6 months ago

  @R3ygoski

  Bernardo:

  Thank you very much for your observations. This challenge particularly gave me a lot of headaches, especially in responsive design, since I chose to use this challenge to practice grid css.

  Regarding semantic labels, it is something that I am going to start putting into practice starting with the next challenge, since it is something that I want to incorporate as a good practice.

  Thank you very much for this feedback. I really appreciate it, since it is these types of observations that help one become better every day.

  1