My solution for the Challenge

Community feedback

• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi @Abasalamin91,

  Nice job on completing the challenge

  You can center the columns by using CSS flex on the parent container in your it's the body element. Replace you body rule with the following one to center the columns in the middle of the page.

  body {
      background-color: hsl(30, 38%, 92%);
      align-items: center;
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
      min-height: 100vh;
  }
  

  Marked as helpful

  1

  ---

  

  Abas Alamin•20

  @Abasalamin91Posted about 2 years ago

  Hi @hyrongennike
  Thanks for your feed back, very helpful.

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi Abas Alamin, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great start and great first solution! You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code:

  You did a good work putting everything together in this challenge, something you can do to improve the image that needs to change between mobile and desktop is to use <picture> instead of <img> wrapped in a div. Look that for SEO and search engine reasons isn’t a better practice import this product image with CSS since this will make harder to the image be found. You can manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device (phone / computer) Here’s a guide about how to use picture: https://www.w3schools.com/tags/tag_picture.asp

  Think about using relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices.Anyhow, if we want a more accessible website, then we should use rem instead of px. REM does not just apply to font size, but to all sizes as well.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Abas Alamin•20

  @Abasalamin91Posted about 2 years ago

  Hi @correlucas I'm very great full for your help, I really appreciate your time for reviewing my code. Thanks a lot.

  1