Design comparison
Solution retrospective
Hey Frontend Mentor family!
First challenge, I'd love to get some feedback on areas of improvement!
- I actually couldn't get my text to match the design for whatever reason, any ideas?
Please check out my GitHub repo to see what I learned/struggled with, but in a nutshell:
- First time using LESS to write my CSS, I found it helped a lot with workflow efficiencies.
- For future projects, I hope to break down each component more to save further editing classes in the middle of developing,
Features I added:
- Cool custom effect on the link to GitHub
- Cheeky little zoom effect on the image
- Box-Shadow just for the card to pop a little from the background.
All and any feedback is welcome!
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @elliottkan, congratulations for your first solution! 👋 Welcome to the Frontend Mentor Coding Community!
👏 Great start and great first solution! You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code:
1.You did a good work putting everything together in this challenge, something you can do to improve the image that needs to change between mobile and desktop is to use
<picture>
instead of<img>
wrapped in a div. You can manage both images inside the<picture>
tag and use the html to code to set when the images should change setting the devicemax-width
depending of the device (phone / computer) Here’s a guide about how to usepicture
:https://www.w3schools.com/tags/tag_picture.asp
2.The box-shadow is a bit too evident, this is due the
opacity
andblur
. The secret to create a perfect and smooth shadow is to have low values foropacity
and increaseblur
try this value instead:box-shadow: 12px 7px 20px 6px rgb(57 75 84 / 8%);
If you’re not familiar to box-shadow you can use this site to create the shadow design and then just drop the code into the CSS: https://html-css-js.com/css/generator/box-shadow/
✌️ I hope this helps you and happy coding!
Marked as helpful0 - @KTrick01Posted about 2 years ago
Hi! Congratulations for your first challenge! After taking a look at your code it seems that you didn't import properly the fonts that you need, that's why your solution doesn't match the design, to fix it you only need to paste this line in the head of your main CSS:
@import url('https://fonts.googleapis.com/css2?family=Fraunces:opsz,[email protected],700&family=Montserrat:wght@500;700&display=swap');
Hope that it helps!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord