Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

My solution! (Flexbox & CSS variables)

P
Haikal Yusufβ€’ 30

@waffledood

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi all, this is my attempt at the challenge

For the desktop view, i think my attempt is fine

But would love feedback/suggestions on the mobile view as I am still new to media queries! I set the breakpoint at 900px but i don't think that's right

Community feedback

Daniel πŸ›Έβ€’ 44,230

@danielmrz-dev

Posted

Hello @waffledood!

Your solution looks great!

I have a couple of suggestions (about semantic HTML) for improvement:

πŸ“Œ First: Use <main> to wrap the main content instead of <div>.

Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.

πŸ“Œ Second: Use the HTML Headings (<h1> to <h6>) for the titles instead of <div>.

Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.

  • <h1> defines the most important heading.

  • <h6> defines the least important heading.

  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, great job!

Marked as helpful

1

P
Haikal Yusufβ€’ 30

@waffledood

Posted

@danielmrz-dev wow! thanks for the very detailed explanation Daniel! appreciate the feedback :) and thank you for taking the time to write this up!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord