Design comparison
Solution retrospective
I am very happy with the help that doing these projects provides, I feel that I improved a lot in covering details. If there is something I would improve it would be the way I apply sizes and measurements. Regarding the rest I am very happy. β€
What challenges did you encounter, and how did you overcome them?I had a little difficulty making the size of the card and the other elements as close to the project example without using pixels, so instead I used em and rem. In the end I was able to apply them after several tests with measures that I think could be improved for next time.
What specific areas of your project would you like help with?I would like help with the measures I applied, I'm not entirely sure if they are correct or if there are better ways to apply them.
Community feedback
- @DylandeBruijnPosted 4 months ago
@RomPirsZ
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve βοΈ
-
I suggest adding a bit of
padding
to yourbody
element so the card has some space around it on smaller viewports. -
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
-
I suggest using clear descriptive CSS classes like
.card
,.card-title
and.card-description
. -
Try using semantic HTML elements like
main
,section
andarticle
. -
Try using using relative CSS units like
rem
andem
they make your layout more adaptable. -
Be careful with setting a fixed
width
andheight
on your elements. If the content in these elements grows beyond these restrictions youβll run into overflow issues. Keeping theheight
atauto
- whichblock
elements are by default - will be fine in most cases. -
You donβt have to wrap your image in a separate
div
, itβs possible to style it directly to achieve the same result. -
Try centering your card using Flexbox instead of
padding
andmargin
.
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord