My edited solution with other users advices for Product Card Component

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello Mario Alberto, Congratulations on completing this challenge!

  Nice solution and nice code! I can see that you paid a lot of attention to your code/design. If you don’t mind I’ve some tips for you:

  1,THE PICTURE TAG is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  2.You’ve used px as the unit for sizes but the problem with pixels is that its not optimized for multiple devices and screens. So a good fit its to use rem or em that have a better performance and make your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0
• 

  Elaine•11,400

  @elaineleungPosted about 2 years ago

  Hi Mario, welcome to Frontend Mentor, and you did great in completing your first challenge! 😊

  About the text elements and their separation, I'm guessing you're referring to the spacing between the text elements. I had a look at your CSS, and I can see that you're using margin: 0 and padding: 0 on the body and html selector. It's a good start, but it won't cover all the elements, so what you need is to include that in the star selector as a reset rule, and another thing I'll add as a reset here is for the img, so try including these at the top:

  * {
      box-sizing: border-box;
      margin: 0;
      padding: 0;
  }
  img {
     max-width: 100%;
     display: block;
  }
  

  Once you reset the margins so that the browser won't use its default margins, you can add your own margin-top or margin-bottom to help put some spacing between the text elements.

  Some other comments I have here:

  1. I'm viewing your site on my laptop and the top and bottom parts are a bit cut off. Try adding a bit of margin around main so that there's some spacing (try margin: 1.5rem to start). Also, try removing the height: 100% from html and body, and add instead min-height: 100vh to the body only where it's got flexbox.

  2. For the container, you can try a max-width of 600px instead to get it looking closer to the design's width.

  3. I see that you're used article for the image and text containers. Using article for the image is giving you a warning in the HTML validation part of your report because there are no headings. Anyway, article is a good choice, and I might use it for the entire card but not each side of the card (which I'd probably use div for instead).

  4. For the PERFUME label, instead of spacing it yourself and changing it to uppercase manually, try using text-transform: uppercase and letter-spacing: 1px (you can experiment with the value!)

  That's all for now, and I really think this was a great start for you. Hope to see more solutions, and enjoy your time here! 😊

  Marked as helpful

  0

  ---

  

  Mario Alberto Carpegna•30

  @mcarpegnaPosted about 2 years ago

  @elaineleung Hi Elaine. I tryed all of of them and the project has really improved and I learnd some more usefull content. Ty for your time and help!

  1
• 

  რეზი კარანაძე•150

  @rezi-rezikoPosted about 2 years ago

  hello, great job. keep going.

  for text <p>, u can use css element line-height.

  Marked as helpful

  0

  ---

  

  Mario Alberto Carpegna•30

  @mcarpegnaPosted about 2 years ago

  @rezi-reziko I tried but is not what i was looking for. Maybe I can't make me understand. I want to have the text better acomodated, like in the in the example, where words are better separated for ocuping better the space, and so are de lines. Anyway I learnd from your advice. Ty for your time and help!

  0