my solution

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Wrap the content of the html with the main tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  Wrap the <h1> and <p class= description"> in a header tag.

  sample html.
  <main>
  <header> <h1></h1>  <p class= "description"></header>
  <div class= "container">
  ....... its content goes here.
  
  </div>
  </main>
  

  There is no need to give the body a min-width, min-height and padding values.

  Give the main a max-width of 1440px and width of 80% and margin: 0 auto or a width of 80vw and margin: 0 auto, for the left and right side space of the page.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0