@Stroudy
Posted
Exceptional work! You’re showing great skill here. I’ve got a couple of minor suggestions that could make this stand out even more…
-
Using a
<main>tag inside the<body>of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content. This should be your main<div class="card"> -
Having a clear and descriptive
alttext for images is important because it helps people who use screen readers understand the content, making your site more accessible. It also improves SEO, as search engines usealttext to understand the image's context, helping your site rank better, Check this out Write helpful Alt Text to describe images, -
Your heading elements
<h2><h5><Missing H3 H4, Heading elements should be in sequentially-descending order (e.g.,<h1>,<h2>,<h3>) to create a clear content structure, improving accessibility and SEO. Skipping levels or using them out of order can confuse screen readers, affect search engine rankings, and make your content harder to understand.
<h2>Alexander Gusev</h2>
<h5>Moscow, Russia</h5>
- I would put these into a
<ul> <li>, and the text should be wrapped with a<a>so it is accessible with a keyboard using the tab key, Using an<a>tag for navigation is semantically correct, improves accessibility for screen readers, and ensures consistent behavior across browsers, unlike a<button>or a<div>not intended for links.
<a href="https://github.com/WaRaGiSmYnIcKnAmE">GitHub</a>
<a href="https://www.frontendmentor.io/profile/WaRaGiSmYnIcKnAmE">Frontend Mentor</a>
<a style="text-decoration: line-through;">LinkedIn</a>
<a href="https://x.com/WaRaG12375">Twitter</a>
<a href="https://www.instagram.com/sanea_prosto_sanea">Instagram</a>
-
Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset
-
While
pxis useful for precise, fixed sizing, such asborder-width,border-radius,inline-padding, and<img>sizes, it has limitations. Pixels don't scale well with user settings or adapt to different devices, which can negatively impact accessibility and responsiveness. For example, usingpxfor font sizes can make text harder to read on some screens, Check this article why font-size must NEVER be in pixels. In contrast, relative units likeremand adjust based on the user’s preferences and device settings, making your design more flexible and accessible. Usepxwhere exact sizing is needed, but prefer relative units for scalable layouts. If you want a deeper explanation watch this video by Kevin Powell CSS em and rem explained. Another great resource I found useful is this px to rem converter based on the default font-size of 16 pixel.
I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻
Marked as helpful
@WaRaGiSmYnIcKnAmE
Posted
@Stroudy, Thanks for the comments, I will definitely add them to my solution!
@Stroudy
Posted
Hey @WaRaGiSmYnIcKnAmE, No problem bro! You got this!
