My simple solution:)

Community feedback

• 

  Manish Patel•730

  @savvystriderPosted over 1 year ago

  Your solution looks good!

  I would recommend the following, though:

  • You have too much padding/whitespace on larger screens. Trim it down.
  • The mobile image looks a bit warped. You can fix it by adding this property to the image: object-fit: cover;.

  1

  ---

  

  Simplelamer8•90

  @Simplelamer8Posted over 1 year ago

  @savvystrider And also... I can not see that there is too much whitespace on larger screens. Is it due to my laptop's screen???

  1

  

  Simplelamer8•90

  @Simplelamer8Posted over 1 year ago

  @savvystrider Thank you for your feedback! Your second advice really helped my I found out something new.

  1

  

  Manish Patel•730

  @savvystriderPosted over 1 year ago

  @Simplelamer8 You can try simulating larger screen sizes with your web browser.

  1

  

  Manish Patel•730

  @savvystriderPosted over 1 year ago

  @Simplelamer8 That's awesome! It's a really useful property.

  1

  

  Simplelamer8•90

  @Simplelamer8Posted over 1 year ago

  @savvystrider Is this what you are talking about? https://devtoolstips.org/tips/en/simulate-devices/

  1

  

  Manish Patel•730

  @savvystriderPosted over 1 year ago

  @Simplelamer8 Yep!

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  .

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="card"> element with the semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1