My second submition to the qr-code-components
Design comparison
Solution retrospective
I was checking out a cleaner way to code the qr-code challenge, I wasn't happy the mark I got on the previous submission. All comments are welcome.
Community feedback
- @DavidMorgadePosted over 2 years ago
Hello and congrats on finishing the challenge!
The only trouble i'm seeing is that the top image of the component is not loading properly, this is because you are not defining correctly the relative path to the image, you need to change your
img src
fromsrc="/images/image-qr-code.png"
tosrc="./images/image-qr-code.png"
.This is because with the
./
you ensure that the folder 'images' is on that same folder (the folder of your html file)Hope my feedback helped you!
Marked as helpful1@CoderKnight02Posted over 2 years ago@DavidMorgade Thank you very much, what a fail, haha, I already changed the code but it still doesn't work, when I visit the site from github, the image is there, but the comparison image here in Frontend Mentor has no image.
1@CoderKnight02Posted over 2 years ago@DavidMorgade Never mind I generated a screenshot haha I'm new to this in general.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord