Lord Robins• 550
@ZenitsuAg
Posted
Hi Riddler, you've done a great job, but there are a few things you can improve on
- It's better to have your CSS and HTML in separate different files.
- You also forgot to include the images folder that's why the images aren't showing
- You have to wrap your code in a landmark tag like
main
,footer
, for accessibility reasons - Your code is also not responsive, you didn't work on the mobile view so the user-experience on smaller devices is not really great.
- You can update the font-family with this in your CSS:
// Import the font from google
@import url(https://fonts.googleapis.com/css2?family=Lexend+Deca:wght@400&display=swap);
@import url(https://fonts.googleapis.com/css2?family=Big+Shoulders+Display:wght@500;700;900&display=swap)
body {
font-family: "Lexend Deca", monospace;
}
h1 {
font-family: "Big Shoulders Display", serif;
}
- And finally, add some hover effect to the button with:
button:hover {
background-color: *some color*
}
Overall you did great!! Keep up the good work.
Happy Coding :)
Marked as helpful
1