My second JS Challenge

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hey there, Anderson Vallejo! 👋

  Well done on this challenge! 👍

  I suggest,

  • Using flexbox (rather than margin) to center the card component in the viewport (so that it remains in the center on all screen sizes). You might need to add min-height: 100vh to the body in order to make sure that it fills up the entire area of the screen and gives you enough space inside with which to center the card.
  • Wrapping the social media icons in the popup in anchor tags (since they seem like links that would take the user to their respective social media site when clicked).
  • Putting the script tag in the head of the document and add the attribute defer to it. That way, your HTML and JS will be loaded at the same time but the JS will only run until after the HTML is finished loading (meaning the functionality of your site should remain the same, but the JS will load a little faster) Read more about this and other ways of adding script tags to HTML documents here.

  Hope those few tips help. 🙂

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  1
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  look at your challenge in a browser as wide as you can make it. Now slowly make the browser narrow and watch how all of your elements change. Do this with you social menu popup open and closed and then when you see something out of place or responding in a way you do not intend then work to fix the things you see one at a time

  0