Skip to content
Submitted over 2 years ago

My second challenge.

AhmedAlasyotY•110
@Ahmed666313
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I am a beginner I hope you like my design I wish to be a professional programmer

Community feedback

  • Travolgi 🍕•31,400
    @denieldenPosted over 2 years ago

    Hi Ahmed, I took some time to look at your solution and you did a great job!

    Also I have some tips for improving your code:

    • add main tag and wrap the card for Accessibility
    • add descriptive text in the alt attribute of the image
    • You can add the effect :hover creating a div that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution
    • To make it look as close to the design as possible add border-radius: 1rem; to img
    • remove all margin from container class
    • try to use flexbox to the body for center the card. Read here -> best flex guide
    • after, add min-heigth: 100vh to body because Flexbox aligns child items to the size of the parent container

    Overall you did well :)

    Hope this help and happy coding!

    Marked as helpful
    0
    AhmedAlasyotY•110
    @Ahmed666313Posted over 2 years ago

    @denielden Thank you very much for your words, I am very happy with your words, and God willing, the upcoming challenges will be better, thanks again

    1
  • Naveen Gumaste•10,480
    @NaveenGumastePosted over 2 years ago

    Hello Ahmed666313 ! Congo 👏 on completing this challenge

    Let's look at some of your issues, shall we:

    • Warp your card content around the main tag Ex: 👇
    <body>
<main class="container">
*all you content here*
</main>
</body>

    happy Coding😀

    Marked as helpful
    0
    AhmedAlasyotY•110
    @Ahmed666313Posted over 2 years ago

    @Crazimonk Thank you but what distorts your card content around the Ex main tag: 👇

    0
  • Shashree Samuel•9,260
    @shashreesamuelPosted over 2 years ago

    Good job with this challenge Ahmed666313. Keep up the good work

    Your solution looks great however I think your image just needs to resized a little.

    I hope this helps and you will become a professional programmer once you are persistent.

    Cheers, Happy coding 👍

    Marked as helpful
    0
    AhmedAlasyotY•110
    @Ahmed666313Posted over 2 years ago

    @TheCoderGuru Thank you very much for your advice.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord