Design comparison
Solution retrospective
I am new to this world, I appreciate comments and suggestions to improve it. Thank you! Raiquen Cordoba
Community feedback
- @Zy8712Posted about 1 year ago
Your website looks pretty good. The center you box you need to make sure that your body takes up the entire viewport of the page. So just add this to your body's css:
width: 100vw; height: 100vh
Additionally, I think you should add a
cursor: pointer
to your button when it is hovered over. Aside from that you clearly have a solid grasp on a good bit of the fundamentals. Nice work!!Marked as helpful0 - @MaximilianoDanielGarciaPosted about 1 year ago
Hi @Raiquen248, goob job!
Congratulations on completing this challenge! If you are wondering why is not centered is because you need to add
min-height: 100vh;
on body tag styles.One thing you should keep in mind for this and future projects is resetting styles. Let me give you an example:
* { padding: 0; margin: 0; box-sizing: border-box; }
This is necessary because html elements have a padding and margin by default and we remove them for better control.
I hope these suggestion are helpful to you.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord