My responsive design for Intro component with sign-up form html , css.

Community feedback

• 

  Solomon Ekrebe•610

  @krebeDevPosted almost 5 years ago

  I checked in. My observations are the same issues being addressed by @Mattstuddert, particularly the breakpoints. You can improve in those areas.

  1
• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Nice work on this challenge, Mohammed. Here is my feedback after taking a look at your code:

  • Always remember to set * { box-sizing: border-box; } in your CSS file. This will make sure your elements are sized correctly. Here's a good CSS Tricks article on box-sizing if you want to read up further. You'll then be able to add width: 100%; to the .form-control class to get the input elements stretching the width of the form.
  • I'd recommend not using IDs for styling purposes. They're too specific and can't be reused. Instead, I just stick to attribute, class, pseudo, and type selectors.
  • Your breakpoints could do with another round of refinements. For example, the content looks very squashed at 500px.
  • Also, try and work through the accessibility errors to clear them.

  I hope these tips help. Keep up the great work! 🙂

  1