Design comparison
Community feedback
- @MiyaoCatPosted 9 months ago
Looks great! Only a couple small differences I see.
-
In your Instructions section, the list-items are indented. The challenge has them aligned with the sub-header. They're pretty tricky to adjust and I don't really know the best way to go about it. I just added a
margin-left
to mine in this challenge. -
The other correction would be to remove the
border-bottom
underneath the "fats" row.One way to go about this is to use the "+" in your CSS. You could do something like this.border-bottom + .border-bottom { border-top: 1px solid black }
. This means any.border-bottom
directly followed by a.border-bottom
will have a top border. You can also try using atable
for this section. It might be somewhat outdated, but this section seemed primed for this use case. -
In the mobile view, I would remove the margin around the body.
-
Lastly, the link to your source code is broken.
Otherwise amazing work! Keep it up!
Marked as helpful1@dmora219Posted 9 months ago@MiyaoCat Thank you john! maybe ill go back and add some of your tips! Im trying to do atleast 1 challenge a week! that is my goal this year
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord