My QR-code Component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace<div class="container">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  Increase the border-radius of .container.

  Fo a responsive content, give .container a max-width value, reduce the value for it to be equivalent to the width of the design.

  Give h1 and p the same font-size of 15px which is 0.9375rem, the same margin-left and margin-right values.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  TanutsaponJ•40

  @TanutsaponJPosted almost 2 years ago

  @Hassiai Thank you so much : )

  1