Skip to content
Submitted about 2 years ago

My QR code component using HTML/CSS

Riikis•20
@Rikvdev
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I did it using custom properties, BEM methodology, relative REM measurements.

Did I do it right? Are there any errors? Where could I improve to make it better? I would like to read your opinion.

Community feedback

  • Vanza Setia•27,775
    @vanzasetiaPosted about 2 years ago

    Hi, Riikis! 👋

    Congratulations on completing your first Frontend Mentor challenge! 🎉

    I recommend using the body element as the card container. Then, set min-height: 100vh to make sure the body element always fills the entire page. Doing that also still allows the body element to growing if ever needed.

    Then, make the main element as the card element. Also, there's no need for header and div. This way, the HTML markup is more simple.

    Changing the html (or the :root) font-size can cause huge accessibility implications for those users with different font sizes or zoom requirements. I recommend taking a look at these resources to learn more about the issues.

    I hope this helps! Happy coding!

    Marked as helpful
    0
    Riikis•20
    @RikvdevPosted about 2 years ago

    @vanzasetia Thanks for the feedback!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord