amnesia2k• 40
@amnesia2k
Posted
The code includes semantic html, it is accessible and i think i can do better
0
Design comparison
Solution retrospective
What are you most proud of, and what would you do differently next time?
I started learning HTML & CSS on my own not long ago, in preprations for a 4 month fullstack bootcamp starting soon. This is my 1st project here, I'm proud I was able to get it done, and that it looks pretty similar
What challenges did you encounter, and how did you overcome them?
It was pretty straight forward
What specific areas of your project would you like help with?
I think I'm lacking in the resposivness part of the project, would love to get some pointers threre, I'm assuming I should use some sort of @media, but I haven't really gotten to that part in my studies.
I'd also like to know if I have any lines of code which are redundant, so I can improve on slimming down my code (E.G - a few lines of code which can be replaced by just one that does the same thing)
Community feedback
Saeed Bin Mizan• 80
@BluffSet7340
Posted
Looking at the side by side comparison, your solution is basically perfect. Regarding the responsive touch, there's no need to add it as even when you trim the screen size to phone width your solution should fit well. But if you had to, maybe a media query that scales down the container that houses the qr code and text itself, possibly making it easier to scan?
0
enoxDev• 40
@enoxSutrisno
Posted
good...
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord