My QR Code Component Solution

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="qr-container"> with the main tag and <p class="heading"> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

  Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

  To center .qr-ontainer on the page using flexbox, replace the height in the body with min-height: 100vh.

  For a responsive content which wont require a media query for this challenge,

  • Give .qr-container a fixed max-width value, a padding value for all the sides max-width: 320px which is 20rem/em padding:16px which is 1rem/em , a background-color of white and a reduce the border-radius value.
  • Give the img a max-width of 100% and a border-radius value, the rest are not needed.

  Give h1 and p the same font-size of 15px which is 0.9375rem, text-align: center, the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  Eivan•50

  @eivanliongsonPosted over 1 year ago

  @Hassiai thank you! I was trying this out. Made it too complicated. Will fix it with your suggestion.

  0