Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

My QR Code Component Solution

Eivan 50

@eivanliongson

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Hassia Issah 50,670

@Hassiai

Posted

Replace <div class="qr-container"> with the main tag and <p class="heading"> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

To center .qr-ontainer on the page using flexbox, replace the height in the body with min-height: 100vh.

For a responsive content which wont require a media query for this challenge,

  • Give .qr-container a fixed max-width value, a padding value for all the sides max-width: 320px which is 20rem/em padding:16px which is 1rem/em , a background-color of white and a reduce the border-radius value.
  • Give the img a max-width of 100% and a border-radius value, the rest are not needed.

Give h1 and p the same font-size of 15px which is 0.9375rem, text-align: center, the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

1

Eivan 50

@eivanliongson

Posted

@Hassiai thank you! I was trying this out. Made it too complicated. Will fix it with your suggestion.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord