My profile-card-component attempt

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Great work on this.

  A suggestion would be that instead of declaring height: 100vh you could declare min-height: 100vh so that it will make your body's height not capped but will have a minimum set to it since when I looked at dev tools, your card's upper part is cut-off because of the height property declared. Layout is good, the background position is a bit off, but preferences right.

  Overall, great work^

  0
• 

  Vinci Taylaran•185

  @vincitaylaranPosted over 3 years ago

  Good eye for detail, Nick.

  Only adjustment I would make would be for the .card__social-list class. Instead of a solid grey color for the border-top property, I would replace with it rgba(211,211,211,0.5). It's still grey but is less strong on the eyes as it has 0.5 opacity.

  Looking forward to seeing your progress and congrats on completing your first challange 🎉

  0