My Order preview component

Community feedback

• 

  P

  Kamran Kiani•1,280

  @kaamiikPosted about 1 month ago

  • I think your font size did not apply to your page. Take a look how you import your font.

  • You can not wrap text in a div. Use semantic tags and is much better. Here think that which tag is proper for a link.

  • Use rem for your font-size instead of px. You can read this article to see why: https://fedmentor.dev/posts/font-size-px/

  • You also use px for max-width that is wrong. You have to use rem instead.

  1

  ---

  

  Vincin Christmas•150

  @VincinChristmasPosted about 1 month ago

  I think I went to quickly and didn't double check. I will look through this code and revise it. I am totally against px. I don't even see where I used it except for in the initial set up to have the base font-size as 16px@kaamiik

  1
• 

  Adriano•38,270

  @AdrianoEscarabotePosted about 1 month ago

  Hi Vincin Christmas, how are you doing? I really loved the outcome of your project, but I have a few suggestions that I think might be helpful:

  I noticed that your content is not centralized to resolve this we can do the following:

  body {
      font-family: "Red Hat Display", serif;
      font-size: 16px;
      min-height: 100vh;
      width: 100vw;
      margin: 0 auto;
      padding: 0;
      box-sizing: border-box;
      display: flex;
      flex-direction: column;
      background: var(--paleblue);
      align-items: center;
      justify-content: center;
  }
  

  and remove:

  .page-container {
      background: white;
      width: calc(100% - 50px);
      max-width: 350px;
      box-sizing: border-box;
      border-radius: 10px;
      position: relative;
      transition: all 0.3s ease;
      /* margin: auto; */
      /* margin-top: 2rem; */
      border-radius: 12px;
  }
  

  The rest is excellent.

  I hope you find it useful. 👍

  0

  ---

  

  Vincin Christmas•150

  @VincinChristmasPosted about 1 month ago

  thanks. I will revise the code @AdrianoEscarabote

  1

  

  Vincin Christmas•150

  @VincinChristmasPosted about 1 month ago

  this messed up my code, man. Not useful. I found my own solution after trying yours@AdrianoEscarabote

  0